-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #100 from bbc/sinhala-tamil-bengali-font-params-up…
…date Updates Tamil, Sinhala and Bengali font sizes to UX specification
- Loading branch information
Showing
6 changed files
with
504 additions
and
503 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,24 @@ | ||
| | Version | Description | | ||
| |---------|-------------| | ||
| | 5.3.1 | Update arabic fonts for Reith Qalam | | ||
| | 5.3.0 | Add link object and commonly used link class | | ||
| | 5.2.1 | Add helper for reduced motion | | ||
| | 5.1.1 | Use gs-sass-tools @ ^5.0.8 to pull in social colour changes | | ||
| | 5.1.0 | Add alt++ to spacing utility | | ||
| | 5.0.4 | Update gs-sass-tools to version 5.0.5 | | ||
| | 5.0.3 | Use latin script for amharic, tigrinya and gujarati services | | ||
| | 5.0.2 | Add ethiopic script for use by amharic and tigrinya services | | ||
| | 5.0.1 | Use gs-sass-tools @ ^5.0.3 to pull in sport colours changes | | ||
| | 5.0.0 | Use gs-sass-tools @ ^5.0.2 to pull in gel-grid @ ^3.0.0 | | ||
| | 4.1.4 | IE improvements to faux block link | | ||
| | 4.1.3 | Add clear classes | | ||
| | 4.1.2 | Update faux-block link to support seperate href element as well as :before. | | ||
| | 4.1.1 | Bump z-index on faux block links to make them more robust. | | ||
| | 4.1.0 | Updating Bullet pattern with the Essential modifier. | | ||
| | 4.0.0 | Updating Bullet to show icon on core. Updating Faux Block Link for IE compatibility. | | ||
| | 3.4.4 | Bump to bring in [gs-sass-tools#20](https://github.com/bbc/gs-sass-tools/pull/20). | | ||
| | 3.4.3 | Add breakpoints to visually hidden class. | | ||
| | 3.4.2 | Add additional vertical align classes. | | ||
| | 3.4.1 | Using interpolated left & right properties and flipping left & right values. | | ||
| | Version | Description | | ||
| | ------- | --------------------------------------------------------------------------------------------------------- | | ||
| | 5.4.0 | Updates Tamil, Bengali and Sinhala font configurations to reflect latest UX designs | | ||
| | 5.3.1 | Update arabic fonts for Reith Qalam | | ||
| | 5.3.0 | Add link object and commonly used link class | | ||
| | 5.2.1 | Add helper for reduced motion | | ||
| | 5.1.1 | Use gs-sass-tools @ ^5.0.8 to pull in social colour changes | | ||
| | 5.1.0 | Add alt++ to spacing utility | | ||
| | 5.0.4 | Update gs-sass-tools to version 5.0.5 | | ||
| | 5.0.3 | Use latin script for amharic, tigrinya and gujarati services | | ||
| | 5.0.2 | Add ethiopic script for use by amharic and tigrinya services | | ||
| | 5.0.1 | Use gs-sass-tools @ ^5.0.3 to pull in sport colours changes | | ||
| | 5.0.0 | Use gs-sass-tools @ ^5.0.2 to pull in gel-grid @ ^3.0.0 | | ||
| | 4.1.4 | IE improvements to faux block link | | ||
| | 4.1.3 | Add clear classes | | ||
| | 4.1.2 | Update faux-block link to support seperate href element as well as :before. | | ||
| | 4.1.1 | Bump z-index on faux block links to make them more robust. | | ||
| | 4.1.0 | Updating Bullet pattern with the Essential modifier. | | ||
| | 4.0.0 | Updating Bullet to show icon on core. Updating Faux Block Link for IE compatibility. | | ||
| | 3.4.4 | Bump to bring in [gs-sass-tools#20](https://github.com/bbc/gs-sass-tools/pull/20). | | ||
| | 3.4.3 | Add breakpoints to visually hidden class. | | ||
| | 3.4.2 | Add additional vertical align classes. | | ||
| | 3.4.1 | Using interpolated left & right properties and flipping left & right values. | | ||
| | 3.4.0 | Qualify all 1280 utilities with `$gel-grid-1280-toggle-class` to prevent them applying on non-1280 pages. | |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,5 +17,5 @@ | |
| "dependencies": { | ||
| "gs-sass-tools": "[email protected]:bbc/gs-sass-tools.git#^5.0.8" | ||
| }, | ||
| "version": "5.3.1" | ||
| "version": "5.4.0" | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,171 +1,171 @@ | ||
| @if $script == 'bengali' { | ||
| // the gel-body-copy class used on live pages was undefined for world-service sites (non-latin script) | ||
| // so after talking to UX the same settings as pica were used for the new class | ||
| $pica: ( | ||
| 'group-a': ( | ||
| 'font-size': 17px, | ||
| 'line-height': 23px | ||
| ), | ||
| 'group-c': ( | ||
| 'font-size': 20px, | ||
| 'line-height': 26px | ||
| ), | ||
| 'group-d': ( | ||
| 'font-size': 22px, | ||
| 'line-height': 28px | ||
| ) | ||
| ); | ||
| $gel-type-settings: ( | ||
| 'canon': ( | ||
| 'group-a': ( | ||
| 'font-size': 20px, | ||
| 'line-height': 24px | ||
| ), | ||
| 'group-b': ( | ||
| 'font-size': 24px, | ||
| 'line-height': 28px | ||
| ), | ||
| 'group-c': ( | ||
| 'font-size': 32px, | ||
| 'line-height': 36px | ||
| ) | ||
| ), | ||
| 'canon-bold': ( | ||
| 'group-a': ( | ||
| 'font-weight': bold, | ||
| 'letter-spacing': -1px | ||
| ) | ||
| ), | ||
| 'trafalgar': ( | ||
| 'group-a': ( | ||
| 'font-size': 22px, | ||
| 'line-height': 30px | ||
| ), | ||
| 'group-b': ( | ||
| 'font-size': 26px, | ||
| 'line-height': 36px | ||
| ), | ||
| 'group-c': ( | ||
| 'font-size': 38px, | ||
| 'line-height': 50px | ||
| ), | ||
| 'group-d': ( | ||
| 'line-height': 48px | ||
| ) | ||
| ), | ||
| 'trafalgar-bold': ( | ||
| 'group-a': ( | ||
| 'font-weight': bold, | ||
| 'letter-spacing': -1px | ||
| ) | ||
| ), | ||
| 'double-pica': ( | ||
| 'group-a': ( | ||
| 'font-size': 20px, | ||
| 'line-height': 30px | ||
| ), | ||
| 'group-c': ( | ||
| 'font-size': 30px, | ||
| 'line-height': 40px | ||
| ), | ||
| 'group-d': ( | ||
| 'font-size': 32px | ||
| ) | ||
| ), | ||
| 'double-pica-bold': ( | ||
| 'group-a': ( | ||
| 'font-weight': bold, | ||
| 'letter-spacing': -1px | ||
| ) | ||
| ), | ||
| 'great-primer': ( | ||
| 'group-a': ( | ||
| 'font-size': 20px, | ||
| 'line-height': 26px | ||
| ), | ||
| 'group-b': ( | ||
| 'font-size': 18px | ||
| ), | ||
| 'group-c': ( | ||
| 'font-size': 26px, | ||
| 'line-height': 32px | ||
| ), | ||
| 'group-d': ( | ||
| 'font-size': 22px, | ||
| 'line-height': 26px | ||
| ) | ||
| ), | ||
| 'great-primer-bold': ( | ||
| 'group-a': ( | ||
| 'font-weight': bold | ||
| ), | ||
| 'group-b': ( | ||
| 'letter-spacing': -1px | ||
| ) | ||
| ), | ||
| 'pica': $pica, | ||
| 'pica-bold': ( | ||
| 'group-a': ( | ||
| 'font-weight': bold | ||
| ) | ||
| ), | ||
| 'long-primer': ( | ||
| 'group-a': ( | ||
| 'font-size': 18px, | ||
| 'line-height': 23px | ||
| ), | ||
| 'group-c': ( | ||
| 'font-size': 20px, | ||
| 'line-height': 26px | ||
| ), | ||
| 'group-d': ( | ||
| 'line-height': 24px | ||
| ) | ||
| ), | ||
| 'long-primer-bold': ( | ||
| 'group-a': ( | ||
| 'font-weight': bold | ||
| ) | ||
| ), | ||
| 'brevier': ( | ||
| 'group-a': ( | ||
| 'font-size': 14px, | ||
| 'line-height': 20px | ||
| ), | ||
| 'group-d': ( | ||
| 'font-size': 19px, | ||
| 'line-height': 22px | ||
| ) | ||
| ), | ||
| 'brevier-bold': ( | ||
| 'group-a': ( | ||
| 'font-weight': bold | ||
| ) | ||
| ), | ||
| 'minion': ( | ||
| 'group-a': ( | ||
| 'font-size': 12px, | ||
| 'line-height': 16px, | ||
| 'text-transform': uppercase | ||
| ), | ||
| 'group-b': ( | ||
| 'font-size': 15px, | ||
| 'line-height': 18px | ||
| ), | ||
| 'group-c': ( | ||
| 'font-size': 16px, | ||
| 'line-height': 20px | ||
| ), | ||
| 'group-d': ( | ||
| 'font-size': 15px, | ||
| 'line-height': 18px | ||
| ) | ||
| ), | ||
| 'minion-bold': ( | ||
| 'group-a': ( | ||
| 'font-weight': bold | ||
| ) | ||
| ), | ||
| 'body-copy': $pica | ||
| ) !global; | ||
| @if $script == "bengali" { | ||
| // the gel-body-copy class used on live pages was undefined for world-service sites (non-latin script) | ||
| // so after talking to UX the same settings as pica were used for the new class | ||
| $pica: ( | ||
| "group-a": ( | ||
| "font-size": 15px, | ||
| "line-height": 23px, | ||
| ), | ||
| "group-c": ( | ||
| "font-size": 20px, | ||
| "line-height": 26px, | ||
| ), | ||
| "group-d": ( | ||
| "font-size": 17px, | ||
| "line-height": 24px, | ||
| ), | ||
| ); | ||
| $gel-type-settings: ( | ||
| "canon": ( | ||
| "group-a": ( | ||
| "font-size": 27px, | ||
| "line-height": 40px, | ||
| ), | ||
| "group-b": ( | ||
| "font-size": 32px, | ||
| "line-height": 46px, | ||
| ), | ||
| "group-c": ( | ||
| "font-size": 32px, | ||
| "line-height": 36px, | ||
| ), | ||
| ), | ||
| "canon-bold": ( | ||
| "group-a": ( | ||
| "font-weight": bold, | ||
| "letter-spacing": -1px, | ||
| ), | ||
| ), | ||
| "trafalgar": ( | ||
| "group-a": ( | ||
| "font-size": 25px, | ||
| "line-height": 32px, | ||
| ), | ||
| "group-b": ( | ||
| "font-size": 29px, | ||
| "line-height": 36px, | ||
| ), | ||
| "group-c": ( | ||
| "font-size": 38px, | ||
| "line-height": 50px, | ||
| ), | ||
| "group-d": ( | ||
| "line-height": 48px, | ||
| ), | ||
| ), | ||
| "trafalgar-bold": ( | ||
| "group-a": ( | ||
| "font-weight": bold, | ||
| "letter-spacing": -1px, | ||
| ), | ||
| ), | ||
| "double-pica": ( | ||
| "group-a": ( | ||
| "font-size": 22px, | ||
| "line-height": 30px, | ||
| ), | ||
| "group-c": ( | ||
| "font-size": 30px, | ||
| "line-height": 40px, | ||
| ), | ||
| "group-d": ( | ||
| "font-size": 23px, | ||
| ), | ||
| ), | ||
| "double-pica-bold": ( | ||
| "group-a": ( | ||
| "font-weight": bold, | ||
| "letter-spacing": -1px, | ||
| ), | ||
| ), | ||
| "great-primer": ( | ||
| "group-a": ( | ||
| "font-size": 19px, | ||
| "line-height": 28px, | ||
| ), | ||
| "group-b": ( | ||
| "font-size": 20px, | ||
| ), | ||
| "group-c": ( | ||
| "font-size": 26px, | ||
| "line-height": 32px, | ||
| ), | ||
| "group-d": ( | ||
| "font-size": 21px, | ||
| "line-height": 30px, | ||
| ), | ||
| ), | ||
| "great-primer-bold": ( | ||
| "group-a": ( | ||
| "font-weight": bold, | ||
| ), | ||
| "group-b": ( | ||
| "letter-spacing": -1px, | ||
| ), | ||
| ), | ||
| "pica": $pica, | ||
| "pica-bold": ( | ||
| "group-a": ( | ||
| "font-weight": bold, | ||
| ), | ||
| ), | ||
| "long-primer": ( | ||
| "group-a": ( | ||
| "font-size": 13px, | ||
| "line-height": 26px, | ||
| ), | ||
| "group-c": ( | ||
| "font-size": 20px, | ||
| "line-height": 26px, | ||
| ), | ||
| "group-d": ( | ||
| "line-height": 30px, | ||
| ), | ||
| ), | ||
| "long-primer-bold": ( | ||
| "group-a": ( | ||
| "font-weight": bold, | ||
| ), | ||
| ), | ||
| "brevier": ( | ||
| "group-a": ( | ||
| "font-size": 12px, | ||
| "line-height": 20px, | ||
| ), | ||
| "group-d": ( | ||
| "font-size": 16px, | ||
| "line-height": 22px, | ||
| ), | ||
| ), | ||
| "brevier-bold": ( | ||
| "group-a": ( | ||
| "font-weight": bold, | ||
| ), | ||
| ), | ||
| "minion": ( | ||
| "group-a": ( | ||
| "font-size": 10px, | ||
| "line-height": 16px, | ||
| "text-transform": uppercase, | ||
| ), | ||
| "group-b": ( | ||
| "font-size": 12px, | ||
| "line-height": 18px, | ||
| ), | ||
| "group-c": ( | ||
| "font-size": 16px, | ||
| "line-height": 20px, | ||
| ), | ||
| "group-d": ( | ||
| "font-size": 12px, | ||
| "line-height": 18px, | ||
| ), | ||
| ), | ||
| "minion-bold": ( | ||
| "group-a": ( | ||
| "font-weight": bold, | ||
| ), | ||
| ), | ||
| "body-copy": $pica, | ||
| ) !global; | ||
| } |
Oops, something went wrong.