Use C++11 as minimal required only #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <[email protected]>
philipnbbc
approved these changes
May 16, 2024
There was a problem hiding this comment.
Thanks, the changes look good to me. Your links were useful to understand it as was Requiring Language Standards. I also see why you put it in the library CMakeList.txt because it relates to a library target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR adds the ability of choosing the C++ standard used when building the project. So far, it's configured to C++11 only, not giving the chance of using newer C++ standards like 14, 17 and 20.
We discovered this behavior when packaging the BMX project into Conan: conan-io/conan-center-index#23955
As we run the CI with different C++ standards, we noted was not possible to use a different version of C++.
The target_compile_features passes the required standard cxx_std_11 but does not impose as unique supported version. In case passing
-DCMAKE_CXX_STANDARD=14, CMake will use C++14 instead.