Always build with CMAKE_POSITION_INDEPENDENT_CODE=ON

not just for shared library builds. This allows static bmx libraries to be linked into other shared libraries.
bbc · Oct 6, 2023 · a1cd198 · a1cd198
1 parent 1820bda
commit a1cd198
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 12 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -19,10 +19,9 @@ if(MSVC AND BMX_SET_MSVC_RUNTIME AND CMAKE_VERSION VERSION_GREATER_EQUAL 3.15.0)
     set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>DLL")
 endif()
 
-if(BUILD_SHARED_LIBS)
-    # Ensure that static library code can be linked into the dynamic libraries (-fPIC compile option)
-    set(CMAKE_POSITION_INDEPENDENT_CODE ON)
-endif()
+# Ensure that static library code can be linked into the dynamic libraries (-fPIC compile option)
+set(CMAKE_POSITION_INDEPENDENT_CODE ON)
+
 set(CMAKE_CXX_STANDARD 11)
 
 # Set the test samples output directory

diff --git a/deps/libMXF/CMakeLists.txt b/deps/libMXF/CMakeLists.txt
@@ -19,10 +19,9 @@ if(MSVC AND LIBMXF_SET_MSVC_RUNTIME AND CMAKE_VERSION VERSION_GREATER_EQUAL 3.15
     set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>DLL")
 endif()
 
-if(BUILD_SHARED_LIBS)
-    # Ensure that static library code can be linked into the dynamic libraries (-fPIC compile option)
-    set(CMAKE_POSITION_INDEPENDENT_CODE ON)
-endif()
+# Ensure that static library code can be linked into the dynamic libraries (-fPIC compile option)
+set(CMAKE_POSITION_INDEPENDENT_CODE ON)
+
 set(CMAKE_CXX_STANDARD 11)
 
 # Set the test samples output directory

diff --git a/deps/libMXFpp/CMakeLists.txt b/deps/libMXFpp/CMakeLists.txt
@@ -19,10 +19,9 @@ if(MSVC AND LIBMXFPP_SET_MSVC_RUNTIME AND CMAKE_VERSION VERSION_GREATER_EQUAL 3.
     set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>DLL")
 endif()
 
-if(BUILD_SHARED_LIBS)
-    # Ensure that static library code can be linked into the dynamic libraries (-fPIC compile option)
-    set(CMAKE_POSITION_INDEPENDENT_CODE ON)
-endif()
+# Ensure that static library code can be linked into the dynamic libraries (-fPIC compile option)
+set(CMAKE_POSITION_INDEPENDENT_CODE ON)
+
 set(CMAKE_CXX_STANDARD 11)
 
 if(MSVC)