Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #1853] projectile-generic-command should use projectile-fd-executable to find the path for fd #1865

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

miles170
Copy link
Contributor

Closes #1853


Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

Thanks!

…e-fd-executable` to find the path for fd
@miles170
Copy link
Contributor Author

I'm not sure why the CI / test (snapshot) (pull_request) failed.

@bbatsov bbatsov merged commit f34d524 into bbatsov:master Oct 11, 2023
5 of 6 checks passed
@miles170 miles170 deleted the fix-projectile-generic-command branch October 11, 2023 07:45
@bbatsov
Copy link
Owner

bbatsov commented Oct 11, 2023

Thanks for tackling this! The CI failure seems unrelated to your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

projectile-generic-command will try to use fd even if projectile-fd-executable is set to nil
2 participants