Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash on invalid hash table #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CycloneRing
Copy link

Hi @bb107
while using mmpp I faced a crash in my application on initialization when another dll was loaded. I investigated the issue and found the root, I applied a fix that made the application work perfectly however i'm not sure what is exactly the issue however the hashtable is null. by returning in will work later. You may want to check this and make a better fix.

also there was a crash on exit from ntrtl.h which the code doesn't make sense to me

    Flink = Entry->Flink;
    Blink = Entry->Blink;
    Blink->Flink = Flink;
    Flink->Blink = Blink;

I fixed it by validation

if (!Entry) return FALSE;

And I believe it must be

    Blink->Flink = Flink;
    Flink->Blink = Blink;
    Entry->Flink = NULL;
    Entry->Blink = NULL;
  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant