Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jarjar-abrams version to 1.13.1 #44

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Update jarjar-abrams version to 1.13.1 #44

merged 1 commit into from
Jan 18, 2024

Conversation

acourtneybrown
Copy link
Contributor

Newer version of jarjar-abrams update the org.objectweb.asm.Opcodes.ASM# value used for some of the ClassVisitor subclasses, thus avoiding failure like:

Exception in thread "main" java.io.IOException: Unable to transform org/apache/kafka/clients/consumer/internals/SubscriptionState$FetchStates.class
	at com.eed3si9n.jarjar.util.JarTransformer.process(JarTransformer.java:43)
	at com.eed3si9n.jarjar.util.JarProcessorChain.process(JarProcessorChain.java:38)
	at com.eed3si9n.jarjar.JJProcessor.process(JJProcessor.scala:108)
	at com.eed3si9n.jarjarabrams.Shader$.$anonfun$bytecodeShader$6(Shader.scala:119)
	at com.eed3si9n.jarjarabrams.Shader$.$anonfun$shadeFile$1(Shader.scala:20)
	at com.eed3si9n.jarjarabrams.Zip$.$anonfun$transformJarFile$3(Zip.scala:62)
	at com.eed3si9n.jarjarabrams.Zip$.$anonfun$transformJarFile$3$adapted(Zip.scala:55)
	at scala.collection.Iterator.foreach(Iterator.scala:943)
	at scala.collection.Iterator.foreach$(Iterator.scala:943)
	at scala.collection.AbstractIterator.foreach(Iterator.scala:1431)
	at com.eed3si9n.jarjarabrams.Zip$.$anonfun$transformJarFile$2(Zip.scala:55)
	at com.eed3si9n.jarjarabrams.Zip$.$anonfun$transformJarFile$2$adapted(Zip.scala:53)
	at com.eed3si9n.jarjarabrams.Using.apply(Using.scala:24)
	at com.eed3si9n.jarjarabrams.Zip$.$anonfun$transformJarFile$1(Zip.scala:53)
	at com.eed3si9n.jarjarabrams.Using.apply(Using.scala:24)
	at com.eed3si9n.jarjarabrams.Zip$.transformJarFile(Zip.scala:51)
	at com.eed3si9n.jarjarabrams.Shader$.shadeFile(Shader.scala:19)
	at com.eed3si9n.jarjarabrams.Main.process(Main.scala:25)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at com.eed3si9n.jarjar.MainUtil.runMain(MainUtil.java:39)
	at com.eed3si9n.jarjarabrams.Main$.main(Main.scala:32)
	at com.eed3si9n.jarjarabrams.Main.main(Main.scala)
	at com.github.johnynek.jarjar.Main.main(Main.java:5)
Caused by: java.lang.UnsupportedOperationException: PermittedSubclasses requires ASM9
	at org.objectweb.asm.ClassVisitor.visitPermittedSubclass(ClassVisitor.java:281)
	at org.objectweb.asm.ClassVisitor.visitPermittedSubclass(ClassVisitor.java:284)
	at org.objectweb.asm.commons.ClassRemapper.visitPermittedSubclass(ClassRemapper.java:226)
	at org.objectweb.asm.ClassReader.accept(ClassReader.java:706)
	at org.objectweb.asm.ClassReader.accept(ClassReader.java:424)
	at com.eed3si9n.jarjar.util.JarTransformer.process(JarTransformer.java:41)
	... 25 more

@johnynek
Copy link
Collaborator

Thanks for the PR!

@johnynek johnynek merged commit 57067a1 into bazeltools:main Jan 18, 2024
8 checks passed
@acourtneybrown acourtneybrown deleted the jarjar-abrams-1.13.1 branch January 19, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants