Add a Starlark set data type #290
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modeled on the Python 3 set type and the existing implementations in Go, Rust, and the proposed one for Java, with the following differences: * set literals and set comprehensions *not* supported (unlike python3) * `copy()` method *not* supported (unlike python3) because we do not have it on lists or dictionaries. * comparison operators *not* supported (unlike starlark-go and python3) * `update()` method supported (unlike starlark-go) * `isdisjoint()`,`intersection_update()`, `difference_update()`, `symmetric_difference_update()` method supported (unlike starlark-go and starlark-rust) * multiple-argument form of `union()`, `intersection()`, `difference()` and corresponding _update methods supported (unlike starlark-go and starlark-rust). Fixes bazelbuild#264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modeled on the Python 3 set type and the existing implementations in Go, Rust, and the proposed one for Java, with the following differences:
copy()method not supported (unlike python3) because we do not have it on lists or dictionaries.update()method supported (unlike starlark-go)isdisjoint(),intersection_update(),difference_update(),symmetric_difference_update()method supported (unlike starlark-go and starlark-rust)union(),intersection(),difference()and corresponding _update methods supported (unlike starlark-go and starlark-rust).Fixes #264
@adonovan @stepancheg FYI