Make it possible to overwrite skydoc attribute of skylark_doc rule.

Minor style changes.

--
MOS_MIGRATED_REVID=121571467

skydoc/build.proto

@@ -16,6 +16,8 @@ syntax = "proto2";
 
 package skydoc;
 
+option py_api_version = 2;
+
 message Attribute {
   // Indicates the type of attribute.
   enum Discriminator {

skydoc/common_test.py

@@ -14,6 +14,7 @@
 
 import unittest
 
+
 from skydoc import common
 
 

skydoc/macro_extractor.py

@@ -19,6 +19,7 @@
 from skydoc import build_pb2
 from skydoc import common
 
+
 def get_type(expr):
   """Find the type of an expression.
 

skydoc/macro_extractor_test.py

@@ -13,6 +13,7 @@
 # limitations under the License.
 
 
+
 import os
 import tempfile
 import textwrap

skydoc/main.py

@@ -14,6 +14,7 @@
 
 """Documentation generator for Skylark"""
 
+
 import gflags
 import jinja2
 import os
@@ -46,8 +47,10 @@
 DEFAULT_OUTPUT_DIR = '.'
 DEFAULT_OUTPUT_FILE = 'skydoc.zip'
 
+WORKSPACE_DIR = 'io_bazel_skydoc'
 TEMPLATE_PATH = 'skydoc/templates'
 CSS_PATH = 'skydoc/sass'
+
 CSS_FILE = 'main.css'
 CSS_DIR = 'css'
 
@@ -87,7 +90,7 @@ def _runfile_path(path):
       break
 
     raise AssertionError('Cannot find .runfiles directory.')
-  return os.path.join(runfiles_dir, 'io_bazel_skydoc', path)
+  return os.path.join(runfiles_dir, WORKSPACE_DIR, path)
 
 def merge_languages(macro_language, rule_language):
   for rule in rule_language.rule:

skydoc/rule.py

@@ -14,6 +14,7 @@
 
 """Representations used for rendering documentation templates."""
 
+
 import mistune
 from skydoc import build_pb2
 

skydoc/rule_extractor.py

@@ -16,11 +16,13 @@
 
 import ast
 
+
 from skydoc import build_pb2
 from skydoc import common
 from skydoc.stubs import attr
 from skydoc.stubs import skylark_globals
 
+
 SKYLARK_STUBS = {
     "attr": attr,
     "aspect": skylark_globals.aspect,
@@ -38,6 +40,7 @@
 }
 """Stubs for Skylark globals to be used to evaluate the .bzl file."""
 
+
 class RuleDocExtractor(object):
   """Extracts documentation for rules from a .bzl file."""
 

skydoc/rule_extractor_test.py

@@ -12,11 +12,12 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import unittest
+
 
 import os
 import tempfile
 import textwrap
+import unittest
 from google.protobuf import text_format
 from skydoc import build_pb2
 from skydoc import rule_extractor

skydoc/stubs/attr.py

@@ -12,6 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+
 from skydoc import build_pb2
 
 def strcmp(s1, s2):

skylark/skylark.bzl

@@ -39,7 +39,7 @@ def _skylark_library_impl(ctx):
                 transitive_bzl_files = sources)
 
 def _skydoc(ctx):
-  for f in ctx.files._skydoc:
+  for f in ctx.files.skydoc:
     if not f.path.endswith(".py"):
       return f
 
@@ -151,7 +151,7 @@ Example:
 
 _skylark_doc_attrs = {
     "format": attr.string(default = "markdown"),
-    "_skydoc": attr.label(
+    "skydoc": attr.label(
         default = Label("//skydoc"),
         cfg = HOST_CFG,
         executable = True),