Introduce a pure Swift runfiles library #1310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cerisier
force-pushed
the
runfiles_library
branch
from
4e8b878 to
adda967
Compare
cerisier
force-pushed
the
runfiles_library
branch
from
adda967 to
6518806
Compare
cerisier
force-pushed
the
runfiles_library
branch
from
6518806 to
ca0cd32
Compare
fmeum
reviewed
Sep 19, 2024
cerisier
requested review from
aaronsky,
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
cerisier
changed the title
Co-authored-by: Brentley Jones <[email protected]>
luispadron
reviewed
Jan 14, 2025
Co-authored-by: Luis Padron <[email protected]>
Co-authored-by: Luis Padron <[email protected]>
Co-authored-by: Luis Padron <[email protected]>
Co-authored-by: Luis Padron <[email protected]>
Co-authored-by: Luis Padron <[email protected]>
luispadron
approved these changes
Jan 28, 2025
fmeum
approved these changes
Jan 29, 2025
| let lines = content.split(separator: "\n") | ||
| for line in lines { | ||
| let fields = line.split(separator: " ", maxSplits: 1) | ||
| if fields.count == 1 { |
There was a problem hiding this comment.
Optional, but you could already implement support for spaces in runfiles paths, with bazelbuild/bazel@7407cef#diff-eda2cfbaa083288dc8cae33e5028d63831a52cf4967e1e88d4eb02aa103ea56f as a reference.
Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First shot at implementing #890
Main implementation
I followed guidance from @fmeum and based this implementation on the runfiles library of
rules_pythonwhere applicable since this was pointed as the reference implementation.In addition to
rules_pythonimplementation, this implementation uses a similar mechanism as the C++ implementation for deducing theRUNFILES_DIRandRUNFILES_MANIFEST_FILElocation based onargv0.TODO