-
Notifications
You must be signed in to change notification settings - Fork 480
Updated CI structure to increase coverage #865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
53de1e9
to
d041bef
Compare
This draft contains changes from the following PRs: |
8d064c2
to
6efb3f7
Compare
0ba01ae
to
b9db62d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me - I'd be tempted (though it's a big step) to maybe write a tiny python script to generate these, rather than writing them all manually, given at this stage we're building up a bit of a combinatorial explosion...
Yeah, but I don't feel like the jobs change so frequently that it's worth that kind of effort. If the issue is that the yaml is not that clear anymore, I'd ask for some pointers in yaml-fu before trying to write some generation tool 😄. Do you have any suggestions on that front? |
Fair! Now definitely doesn't have to be The Time.
In my experience, it's simply not possible to make yaml more readable :) |
@hlopko If there are no objections from you, I'd like to get this merged. I feel in general it's a good improvement |
I stand aside, feel free to merge :) |
This change is related to #830