Add firefox linux binaries for rust_wasm_bindgen_test
#3320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
force-pushed
the
wasm-bindgen
branch
2 times, most recently
from
74c4d27 to
b70ab85
Compare
|
Without this the Bazel Central Registry CI would have failed since it runs |
UebelAndre
force-pushed
the
wasm-bindgen
branch
2 times, most recently
from
f7bdec2 to
34e1a32
Compare
UebelAndre
force-pushed
the
wasm-bindgen
branch
from
34e1a32 to
d97a822
Compare
illicitonion
approved these changes
Mar 10, 2025
I mean, I developed this on a Mac. If you extract firefox from the dmg (e.g. from https://ftp.mozilla.org/pub/firefox/releases/136.0/mac/en-US/) then this works just fine. Ideally there would be a rule that could do this extraction or Mozilla would host the apps in a tar file somewhere 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The firefox binaries are only available for linux since there is no easy way to extract a
.dmgfor macos and the.exethat firefox distributes for the relevant platforms.Additionally, the
@rules_rust_wasm_bindgen//:test_browsersetting moved to@rules_rust_wasm_bindgen//settings:test_browser