Support local path patching in vendor mode #3274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@illicitonion Friendly ping, an initial round of opinions would be appreciated. |
illicitonion
approved these changes
Mar 7, 2025
Change-Id: I373b86e6af244ec5f7a79a41b6dc12b057ae97db
Tested with: cd examples/crate_universe bazelisk run //vendor_local_patching:crates_vendor bazelisk test //vendor_local_patching:test Change-Id: Icc449d34dc6eb97f7a76132bbe4bdb9ae044061f
jayzhuang
force-pushed
the
patching
branch
4 times, most recently
from
af4dae8 to
a53dba8
Compare
1. Address review comment
2. Fix/add unit tests: bazelisk test //...
3. Fix clippy: bazelisk build //... --config=clippy
4. Fix path patching tests: bazelisk run //:vendor_edit_test_out_of_tree
a. Recognize when patched path is from a temporary Bazel dir, and
rebase properly back to Bazel workspace (previous logic).
b. Don't try to read BUILD.bazel when path patching in
extensions.bzl, since the BUILD file is writted directly to
patched path, which does not necessarily follow the convention
(naming and location) of other generated build files.
Change-Id: Ie3cddbafb7b524c0ea70494d76905475be1fc742
|
Addressed comments and fixed tests. Now CI is passing. PTAL! |
UebelAndre
reviewed
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
pathpatches in Cargo.toml incrate_vendor. See #3241