Skip to content

Bump wasm-bindgen dependencies #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2025

Conversation

UebelAndre
Copy link
Collaborator

No description provided.

@UebelAndre
Copy link
Collaborator Author

This is blocked by rustwasm/wasm-bindgen#4399

@UebelAndre UebelAndre force-pushed the wasm-bindgen-pins branch 2 times, most recently from c48158a to aa8a700 Compare January 9, 2025 16:36
@UebelAndre
Copy link
Collaborator Author

I'm in a bit over my head here. Tests are currently failing with:

exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //rules_js/test:hello_world_wasm_direct_test
-----------------------------------------------------------------------------
(node:22) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)
(node:22) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(node:22) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/44886e0696fee5410020d9bd8d8f80cb/sandbox/linux-sandbox/261/execroot/_main/bazel-out/k8-fastbuild/bin/rules_js/test/hello_world_wasm_direct_test_/hello_world_wasm_direct_test.runfiles/_main/rules_js/test/hello_world_bundler_wasm_bindgen/hello_world_bundler_wasm_bindgen.js:1
import * as wasm from "./hello_world_bundler_wasm_bindgen_bg.wasm";
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at internalCompileFunction (node:internal/vm:76:18)
    at wrapSafe (node:internal/modules/cjs/loader:1283:20)
    at Module._compile (node:internal/modules/cjs/loader:1328:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    at Module.load (node:internal/modules/cjs/loader:1203:32)
    at Module._load (node:internal/modules/cjs/loader:1019:12)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:203:29)
    at ModuleJob.run (node:internal/modules/esm/module_job:195:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:337:24)
    at async main (file:///var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/44886e0696fee5410020d9bd8d8f80cb/sandbox/linux-sandbox/261/execroot/_main/bazel-out/k8-fastbuild/bin/rules_js/test/hello_world_wasm_direct_test_/hello_world_wasm_direct_test.runfiles/_main/rules_js/test/hello_world_wasm_test.mjs:19:17)

Curious if @gregmagolan is willing to provide some suggestions for how to fix this or better test this.

@UebelAndre UebelAndre mentioned this pull request Jan 27, 2025
@UebelAndre UebelAndre force-pushed the wasm-bindgen-pins branch 2 times, most recently from 16d21b4 to 151d0f7 Compare February 13, 2025 17:29
@UebelAndre
Copy link
Collaborator Author

re #3174 (comment)

I've simply disabled the tests: #3266

@UebelAndre UebelAndre marked this pull request as ready for review February 13, 2025 17:30
@UebelAndre UebelAndre enabled auto-merge March 8, 2025 17:33
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing will be "restored" in #3267 meaning a new way to test the wasm files will be added.

@UebelAndre UebelAndre added this pull request to the merge queue Mar 8, 2025
Merged via the queue into bazelbuild:main with commit 4a2cdb9 Mar 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants