Bump min Bazel version to 6.3 #2150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
reviewed
Sep 4, 2023
illicitonion
reviewed
Sep 4, 2023
|
Unfortunately I think coverage issues are present also in 6.3 and onwards bazelbuild/bazel#19098. I updated the PR description though. |
ttiurani
pushed a commit
to ttiurani/rules_rust
that referenced
this pull request
Sep 15, 2023
A future Bazel version will contain a breaking API change. bazelbuild#2072 is preparing the `rules_rust` codebase for it, however it relies on Bazel API changes present in `6.3.0` and not `6.0.0`. As per discussion there bazelbuild#2072 (comment), looks like maintainers are fine with bumping the minimum Bazel version to `6.3.0`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A future Bazel version will contain a breaking API change. #2072 is preparing the
rules_rustcodebase for it, however it relies on Bazel API changes present in6.3.0and not6.0.0. As per discussion there #2072 (comment), looks like maintainers are fine with bumping the minimum Bazel version to6.3.0.