Consolidate rust_prost_library and fix extension-only proto generation. #2047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@UebelAndre & @illicitonion, please take a look when you have a chance. |
|
I'm amazed by the speed at which you come up with these fixes 😍 Thank you so much for your efforts! ❤️ UX-wise I think this simplified API is a good change. |
illicitonion
approved these changes
Jul 5, 2023
|
Thanks! |
UebelAndre
reviewed
Jul 5, 2023
Silcet
pushed a commit
to Silcet/rules_rust
that referenced
this pull request
Jul 10, 2023
…n. (bazelbuild#2047) This PR consolidates rust_prost_library and rust_tonic_library into one rule; `rust_prost_library`. `rust_prost_library` will generate tonic services if you provide a `tonic_plugin` in the toolchain definition. If you do not provide that plugin and you try to build a proto with services, it will print a warning that you should add a `tonic_plugin`. This PR also handles extension-only proto files. Prost does not generate a file if there are no messages, enums, or services and it appears that Prost doesn't even support proto2 extensions. So to work around this issue, protoc_wrapper will generate an empty `.rs` file in the case that there are only extensions defined in a file. Closes: bazelbuild#2046
Silcet
pushed a commit
to Silcet/rules_rust
that referenced
this pull request
Jul 10, 2023
…n. (bazelbuild#2047) This PR consolidates rust_prost_library and rust_tonic_library into one rule; `rust_prost_library`. `rust_prost_library` will generate tonic services if you provide a `tonic_plugin` in the toolchain definition. If you do not provide that plugin and you try to build a proto with services, it will print a warning that you should add a `tonic_plugin`. This PR also handles extension-only proto files. Prost does not generate a file if there are no messages, enums, or services and it appears that Prost doesn't even support proto2 extensions. So to work around this issue, protoc_wrapper will generate an empty `.rs` file in the case that there are only extensions defined in a file. Closes: bazelbuild#2046
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates rust_prost_library and rust_tonic_library into one rule;
rust_prost_library.rust_prost_librarywill generate tonic services if you provide atonic_pluginin the toolchain definition. If you do not provide that plugin and you try to build a proto with services, it will print a warning that you should add atonic_plugin.This PR also handles extension-only proto files. Prost does not generate a file if there are no messages, enums, or services and it appears that Prost doesn't even support proto2 extensions. So to work around this issue, protoc_wrapper will generate an empty
.rsfile in the case that there are only extensions defined in a file.Closes: #2046