-
Notifications
You must be signed in to change notification settings - Fork 474
Added support for producing distribution archives #1194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
One question though. Right now we release everything in rules_rust, including experimental things and things not covered by the compatibility policy. Alternative approach would be to only release stable stuff and ask users who need more to use HEAD. That would emphasize that they are using something not well supported.
I think I'm fine either way, I just wanted to make sure there was a discussion about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One question though. Right now we release everything in rules_rust, including experimental things and things not covered by the compatibility policy. Alternative approach would be to only release stable stuff and ask users who need more to use HEAD. That would emphasize that they are using something not well supported.
I think I'm fine either way, I just wanted to make sure there was a discussion about this.
Also fine either way :)
I think experimental things are fine to include in an archive like this. We should not have something missing from the compatibility policy (even if it's just saying we're ignoring it). I like the idea that release artifacts are by Bazel so if we wanted to have an artifact with no experimental rules, I'd have thought that'd be a separate release artifact, much like the "core" package from @hlopko does that sound reasonable? |
Gonna merge for the time being but am happy to continue the discussion and make changes so everyone's happy. |
It seems that bazelbuild#1194 accidentally excluded //tools/rust_analyzer from the distribution. This change adds rust_analyzer back.
This change introduces the
//distro:rules_rust
target which produces a minimal archive ofrules_rust
. This archive is one of the final stepping stones to closing out #415 which is something I'd like to see done this week. This PR is required by #1195 which updates the release workflow to produce this new tar archive as a release artifact for easy user consumption.