-
Notifications
You must be signed in to change notification settings - Fork 479
Update CI structure #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
Would love your thoughts @illicitonion @dfreese @hlopko |
#828 would probably also be added as another set of tests
Total Jobs: |
I think the only thing left to do here is add something which tests a pinned version of Rust. Not quite sure how to implement a toggle such that a particular CI job could define this. |
This was completed by #1720 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now we have CI jobs that build and test the core rules and docs and examples in the same job. This may be nice from the perspective of resource management in CI but means that we have very coupled test cases and can end up in situations where examples have crossed boundaries into integration tests (#789) and are no longer useful as examples users can look at to figure out what to do or we introduce a coupling with an aspect and cannot build without a particular configuration (#824 (review)).
I'd propose having the following structure for CI
//...
with no configurations//...
clang with no configurations//...
min Bazel version with no configurations//...
with all aspectsTotal Jobs:
15
->22
edit: readability
ps: If it's not obvious,
//...
would continue to not include examples and docs. We would re-writedocs/WORKSPACE.bazel
andexamples/WORKSPACE.bazel
to be normal looking WORKSPACE files (not all just call wrapper macros).The text was updated successfully, but these errors were encountered: