Support custom compression program

[HackAttack]

Resolves #59

[aiuto]

Yes. But the xz code path is also non optimal. It is also not used for most people, since their python will have lzma support and we will use the inline compressor.

…

On Wed, Apr 7, 2021 at 12:38 PM Michael Hackner ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pkg/archive.py <#320 (comment)>: > @@ -422,7 +425,14 @@ def close(self): # Close the gzip file object if necessary. if self.fileobj: self.fileobj.close() - if self.use_xz_tool: + if self.compressor: Isn’t this the exact same approach used by the xz code below? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#320 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXHHHDHR7N4B3DTM2DTQ5TTHSDCFANCNFSM4ZQW6AIA> .

[aiuto]

Much nicer. Thanks.

The thing it needs now is some sort of test, or at least an executable example in the /examples tree. Otherwise, this will get inevitably get broken.

[aiuto]

One last thing, can you add this to .bazelci/test.yaml in the windows section

• "//tests:test_tar_compression"

[HackAttack]

Done. Should this be necessary though, since it is a data dependency of archive_test, which is in the list?

[aiuto]

Oh.... dang. The name fooled me. "test_tar_compression" is not a test, though it sounds like one.
The whole 'archive_test' is a mess. I should make it several distinct ones, but that is not your problem.
Thanks for adding this.