Add validation for platform type attribute in apple_{,static}_xcframework rule
#2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`apple_{,static}_xcframework` rule
The platform type attributes (`ios`, `tvos`,...) aren't mandatory, but
at least one of them has to be set. It wasn't clear in the documentation
that one of these is required, because there is another attribute
`minimum_os_versions` which also mentions platform types.
Previously not setting any of these led to an error in:
```
Error in link_multi_arch_static_library: unexpected empty key in split transition
```
which wasn't that much useful.
thii
requested review from
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
segiddins
as code owners
brentleyjones
approved these changes
Oct 30, 2023
mattrobmattrob
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The platform type attributes (
ios,tvos,...) aren't mandatory, butat least one of them has to be set. It wasn't clear in the documentation
that one of these is required, because there is another attribute
minimum_os_versionswhich also mentions platform types.Previously not setting any of these led to an error in:
which wasn't that much useful.