Skip to content

Commit

Permalink
Remove objc_framework references from docs (#2425)
Browse files Browse the repository at this point in the history
`objc_framework` was deleted from the Bazel codebase in January 2019.

Signed-off-by: Brentley Jones <[email protected]>
brentleyjones authored Mar 6, 2024
1 parent 873072f commit 824fc38
Showing 1 changed file with 0 additions and 50 deletions.
50 changes: 0 additions & 50 deletions doc/frameworks.md
Original file line number Diff line number Diff line change
@@ -245,53 +245,3 @@ apple_dynamic_framework_import(
```

![Framework imports](frameworks4.png)

## Migration

`apple_dynamic_framework_import` and `apple_static_framework_import` are
Starlark replacement rules for the native `objc_framework` rule, which is
deprecated and slated to be removed in Q1-19. The following is an example of how
migration will happen for `objc_framework` targets for Dynamic Frameworks:

```build
objc_framework(
name = "MyPrebuiltDynamicFramework",
framework_imports = glob(["MyPrebuiltDynamicFramework.framework/**"]),
is_dynamic = 1,
sdk_dylibs = [...],
sdk_frameworks = [...],
weak_sdk_frameworks = [...],
)
apple_dynamic_framework_import(
name = "MyPrebuildDynamicFramework",
framework_imports = glob(["MyPrebuiltDynamicFramework.framework/**"]),
)
```

Notice that the `sdk_frameworks`, `weak_sdk_frameworks` and `sdk_dylibs` were
removed. This is because Dynamic Frameworks are already linked, and this
information should already be encoded in the binary. If your build starts
failing after this change, it means that the import was masking another library
that required an extra SDK framework/dylib. That library should be fixed
instead.

For Static Frameworks, migration would look like this:

```build
objc_framework(
name = "MyPrebuiltStaticFramework",
framework_imports = glob(["MyPrebuiltStaticFramework.framework/**"]),
sdk_dylibs = [...],
sdk_frameworks = [...]
weak_sdk_frameworks = [...],
)
apple_static_framework_import(
name = "MyPrebuildStaticFramework",
framework_imports = glob(["MyPrebuiltStaticFramework.framework/**"]),
sdk_dylibs = [...],
sdk_frameworks = [...]
weak_sdk_frameworks = [...],
)
```

0 comments on commit 824fc38

Please sign in to comment.