Skip to content

Commit

Permalink
Make aarch64 an alias of arm64
Browse files Browse the repository at this point in the history 
On Apple silicon Macs, auto-detected host platform constraints' cpu is
aarch64, but arm64 is used everywhere else. This change ensures that you
will get the same cpu when your target depends on an arm64 or an aarch64
cpu contraint.
  • Loading branch information
@thii
thii committed Dec 10, 2020
1 parent 5400325 commit e20c932
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cpu/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ filegroup(
constraint_setting(name = "cpu")

# TODO(b/136237408): Remove this generic CPU name and replace with a specific one.
constraint_value(
alias(
name = "aarch64",
constraint_setting = ":cpu",
actual = ":arm64",
)

# TODO(b/136237408): Remove this generic CPU name and replace with a specific one.
Expand Down

1 comment on commit e20c932

@meteorcloudy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @katre Can we have a new release of the platforms repo so that I can upgrade platforms in Bazel to include this change? Like the PR description said, we need this on Apple Silicon.

Please sign in to comment.