Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ListChanges method of Piper API in intellij-ext #6350

Open
wants to merge 1 commit into
base: google
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ext/proto/perforce/get_client_context_rpc.proto
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ syntax = "proto2";
package com.google.idea.blaze.ext.perforce;

import "ext/proto/perforce/base.proto";
import "ext/proto/perforce/status.proto";

option java_package = "com.google.idea.blaze.ext.p4";

Expand All @@ -14,4 +13,4 @@ message GetClientContextRequest {
message GetClientContextResponse {
optional string workspace_name = 1;
optional string workspace_id = 2;
}
}
4 changes: 2 additions & 2 deletions ext/proto/perforce/integrate_rpc.proto
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ syntax = "proto2";
package com.google.idea.blaze.ext.perforce;

import "ext/proto/perforce/base.proto";
import "ext/proto/perforce/source_file.proto";
import "ext/proto/perforce/status.proto";

option java_package = "com.google.idea.blaze.ext.p4";
Expand All @@ -28,4 +27,5 @@ message IntegrateFilesRequest {

message IntegrateFilesResponse {
optional string destination_file = 3;
}
optional PerforceStatus perforce_status = 1002;
}
5 changes: 4 additions & 1 deletion ext/proto/perforce/patch_rpc.proto
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ syntax = "proto2";
package com.google.idea.blaze.ext.perforce;

import "ext/proto/perforce/base.proto";
import "ext/proto/perforce/status.proto";

option java_package = "com.google.idea.blaze.ext.p4";

Expand All @@ -18,4 +19,6 @@ message PatchChangeRequest {
optional string custom_description_prefix = 8;
}

message PatchChangeResponse {}
message PatchChangeResponse {
optional PerforceStatus perforce_status = 1002;
}
1 change: 0 additions & 1 deletion ext/proto/perforce/revert_files_rpc.proto
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ syntax = "proto2";
package com.google.idea.blaze.ext.perforce;

import "ext/proto/perforce/base.proto";
import "ext/proto/perforce/source_file.proto";
import "ext/proto/perforce/status.proto";

option java_package = "com.google.idea.blaze.ext.p4";
Expand Down
81 changes: 81 additions & 0 deletions ext/proto/perforce/service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,22 @@ syntax = "proto2";

package com.google.idea.blaze.ext.perforce;

import "ext/proto/perforce/annotation_rpc.proto";
import "ext/proto/perforce/change_rpc.proto";
import "ext/proto/perforce/depot_file_rpc.proto";
import "ext/proto/perforce/file_content_rpc.proto";
import "ext/proto/perforce/file_state_rpc.proto";
import "ext/proto/perforce/get_client_context_rpc.proto";
import "ext/proto/perforce/integrate_rpc.proto";
import "ext/proto/perforce/mail_change_rpc.proto";
import "ext/proto/perforce/patch_rpc.proto";
import "ext/proto/perforce/resolve_conflicts_rpc.proto";
import "ext/proto/perforce/revert_files_rpc.proto";
import "ext/proto/perforce/submit_change_rpc.proto";
import "ext/proto/perforce/switch_client_rpc.proto";
import "ext/proto/perforce/sync_files_rpc.proto";
import "ext/proto/perforce/upload_change_rpc.proto";
import "ext/proto/perforce/workspace_file_rpc.proto";
import "ext/proto/perforce/workspace_rpc.proto";

option java_multiple_files = true;
Expand Down Expand Up @@ -35,4 +47,73 @@ service PiperService {
// Update the state and type of files that are open in a Piper workspace.
rpc UpdateFileStates(UpdateFileStatesRequest)
returns (stream UpdateFileStatesResponse) {}

// Delete a change.
rpc DeleteChange(DeleteChangeRequest) returns (DeleteChangeResponse) {}

// Retrieve annotations for files stored in the Piper depot.
rpc GetAnnotations(GetAnnotationsRequest)
returns (stream GetAnnotationsResponse) {}

// A single RPC version of GetChanges. If you're querying multiple changes at
// once, please use GetChanges.
rpc GetChange(GetChangeRequest) returns (GetChangeResponse) {}

// Gets client context
rpc GetClientContext(GetClientContextRequest)
returns (GetClientContextResponse) {}

// Integrates revisions from one branch to another.
rpc IntegrateFiles(IntegrateFilesRequest)
returns (stream IntegrateFilesResponse) {}

// Search for matching files and return metadata about each match.
rpc ListDepotFiles(ListDepotFilesRequest)
returns (stream ListDepotFilesResponse) {}

// Search for matching changes and return metadata about each match.
rpc ListChanges(ListChangesRequest) returns (stream ListChangesResponse) {}

// Search for matching files in the workspace and return metadata about each
// match.
rpc ListWorkspaceFiles(ListWorkspaceFilesRequest)
returns (stream ListWorkspaceFilesResponse) {}

// Searches for matching workspaces, and retrieves metadata for each match.
rpc ListWorkspaces(ListWorkspacesRequest)
returns (stream ListWorkspacesResponse) {}

// List CitC switch clients of a user. Similar to p4 switches.
rpc ListSwitchClients(ListSwitchClientsRequest)
returns (ListSwitchClientsResponse) {}

// Move (rename) file(s) in a workspace.
rpc MoveFiles(MoveFilesRequest) returns (stream MoveFilesResponse) {}

// Patches a change to a workspace.
rpc PatchChange(PatchChangeRequest) returns (PatchChangeResponse) {}

// Reverts files that are open in a Piper workspace.
rpc RevertFiles(RevertFilesRequest) returns (stream RevertFilesResponse) {}

// Update the revision and content of files that are in a Piper workspace.
rpc SyncFiles(SyncFilesRequest) returns (stream SyncFilesResponse) {}

// Edit/Create a change.
rpc UpdateChange(UpdateChangeRequest) returns (UpdateChangeResponse) {}

// Updates a CitC switch client to point to the new target or create a new
// switch client with the new target.
rpc UpdateSwitchClient(UpdateSwitchClientRequest)
returns (UpdateSwitchClientResponse) {}

// Uploads a pending change to Critique.
rpc UploadChangeToCritique(UploadChangeToCritiqueRequest)
returns (UploadChangeToCritiqueResponse) {}

// Runs presubmits and/or submits a numbered pending change.
rpc SubmitChange(SubmitChangeRequest) returns (stream SubmitChangeResponse) {}

// Runs presubmits and mails pending change for review.
rpc MailChange(MailChangeRequest) returns (stream MailChangeResponse) {}
}