Skip to content

Commit

Permalink
Remove non-jars from JavaToolchainIdeInfo.
Browse files Browse the repository at this point in the history
They get put into the jar cache (after renaming to .jar as part of the name
hashing) and causes compilation failures when put on the classpath.

PiperOrigin-RevId: 285818460
  • Loading branch information
Googler authored and copybara-github committed Dec 16, 2019
1 parent 1da5a7c commit c4bbb03
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion aspect/intellij_info_impl.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -829,7 +829,11 @@ def collect_java_toolchain_info(target, ide_info, ide_info_file, output_groups):
toolchain = target.java_toolchain
javac_jars = []
if hasattr(toolchain, "tools"):
javac_jars = [artifact_location(f) for f in toolchain.tools.to_list()]
javac_jars = [
artifact_location(f)
for f in toolchain.tools.to_list()
if f.basename.endswith(".jar")
]
ide_info["java_toolchain_ide_info"] = struct_omit_none(
source_version = toolchain.source_version,
target_version = toolchain.target_version,
Expand Down

0 comments on commit c4bbb03

Please sign in to comment.