Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovated all Rust examples #503

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

marvin-hansen
Copy link
Contributor

@marvin-hansen marvin-hansen commented Sep 15, 2024

In response to some failing CI tests against Bazel 8, I checked all Rust examples and renovated all of them.

Most examples are good with Bazel 8 and just got a makeover, that means:

  • Bumped up versions
  • Added a gitignore
  • Added a coherent bazelrc that enables Bazemod and comes with sensible defaults
  • Vendored example 09 / OCI to prevent the chance of breaking similar to example 8 a while ago.
  • Set Bazel to version 7.31, which is the default now for rules_rust

However, HEAD somehow breaks some internals of crate universe, which affects examples 4, 5, and 7.

I see the same issue as in the failing CI build, so I am working on a repro and fill an issue with rules_rust.

Now, the issue may take a bit of time to investigate and resolve, so in the meantime, please review this PR.

Build is green, so at least that's out of the way.

Signed-off-by: Marvin Hansen <[email protected]>
@marvin-hansen marvin-hansen changed the title Renovated Rust examples Renovated all Rust examples Sep 15, 2024
@marvin-hansen
Copy link
Contributor Author

marvin-hansen commented Sep 15, 2024

Update:

Repro: https://github.com/marvin-hansen/bazel_8_rust

The underlying issue is possibly related to: bazelbuild/rules_rust#2801

@Wyverald
Copy link
Member

@illicitonion mind taking a look?

Also just be careful, the diff is gi-gan-tic -- it froze my Chrome tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants