Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: Fix .bazelversion location #533

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

claymation
Copy link

The Python and Go implementations both look for .bazelversion only in the workspace root.

Copy link

google-cla bot commented Jan 19, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@claymation
Copy link
Author

Signed CLA after the fact, how can I re-run the check?

@albertocavalcante
Copy link
Contributor

@claymation You should be able to click on the "details" for the cla/google action and then there will be a rescan option as below:

🔁 New Contributors: Update this check after signing the CLA by clicking here.

@meteorcloudy meteorcloudy added the awaiting-user-response Awaiting a response from the author label Jul 23, 2024
@albertocavalcante
Copy link
Contributor

@claymation do you still intend to proceed with this PR?

The Python and Go implementations both look for `.bazelversion` only in the workspace root.
@claymation
Copy link
Author

@albertocavalcante yes, rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-user-response Awaiting a response from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants