Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make genquery work in external repos #24328

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make genquery work in external repos #24328

wants to merge 1 commit into from
+61 −35

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Nov 14, 2024 •
edited
Loading

Previously, some parts of the query implementation would evaluate labels relative to the main repo in all cases.

fmeum added a commit to fmeum/bazel that referenced this pull request Nov 14, 2024
@fmeum
Apply the main repo mapping in BuildIntegrationTestCase
4a6529a 
Some `get*` methods worked with apparent repo names, others didn't, which is a hurdle to contributions in this area (as observed while working on bazelbuild#24328).
@fmeum fmeum mentioned this pull request Nov 14, 2024
Closed
@fmeum fmeum requested a review from Wyverald November 14, 2024 13:13
@fmeum fmeum marked this pull request as ready for review November 14, 2024 13:13
@fmeum fmeum requested a review from lberki as a code owner November 14, 2024 13:13
@fmeum fmeum removed the request for review from lberki November 14, 2024 13:13
@github-actions github-actions bot added team-Performance Issues for Performance teams awaiting-review PR is awaiting review from an assigned reviewer labels Nov 14, 2024
copybara-service bot pushed a commit that referenced this pull request Nov 18, 2024
@fmeum @copybara-github
Apply the main repo mapping in BuildIntegrationTestCase
9534199 
Some `get*` methods worked with apparent repo names, others didn't, which is a hurdle to contributions in this area (as observed while working on #24328).

Closes #24329.

PiperOrigin-RevId: 697548136
Change-Id: I24c3624875d1d1110ee8685656b88fffe3be6d95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Awaiting requested review from Wyverald

Assignees
No one assigned
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Performance Issues for Performance teams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fmeum