Skip to content

Commit

Permalink
Update Bazel's embedded JDK to 23.0.1
Browse files Browse the repository at this point in the history
In addition to performance improvements, this JDK release contains a fix for https://bugs.openjdk.org/browse/JDK-8330077, which allows `--watchfs` to handle a configurable number of changes to a watched path rather than maxing out at 500.

Windows arm64 can switch to Zulu JDK 21.

Since async-profiler is released very rarely (last release in January) and the latest release is not compatible with JDK 23, this PR consumes a recent nightly release instead. This has the side effect of removing a bit of bloat from the server jar as it no longer contains async profiler's native library for all OSes/arches.

Closes #24609.

PiperOrigin-RevId: 707717223
Change-Id: I29fe86eca1e0deeae813e7dbbf7d60859e3cba5e
  • Loading branch information
fmeum authored and copybara-github committed Dec 19, 2024
1 parent 8ae2570 commit e586a5e
Show file tree
Hide file tree
Showing 10 changed files with 563 additions and 107 deletions.
1 change: 1 addition & 0 deletions BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ pkg_tar(
srcs = [
"//third_party/googleapis:dist_jars",
"//third_party/grpc-java:grpc_jars",
"@async_profiler//file",
"@com_google_protobuf//:protobuf_java",
"@com_google_protobuf//:protobuf_java_util",
"@com_google_protobuf//:protobuf_javalite",
Expand Down
10 changes: 9 additions & 1 deletion MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@ maven.install(
"org.threeten:threeten-extra:1.5.0",
"org.tukaani:xz:1.9",
"org.yaml:snakeyaml:1.28",
"tools.profiler:async-profiler:3.0",
# The following jars are for testing.
# junit is not test only due to //src/java_tools/junitrunner/java/com/google/testing/junit/junit4:runner,
# and hamcrest is a dependency of junit.
Expand Down Expand Up @@ -364,6 +363,15 @@ http_file(
urls = ["https://github.com/jqlang/jq/releases/download/jq-1.5/jq-win64.exe"],
)

async_profiler_repos = use_extension("//:repositories.bzl", "async_profiler_repos")
use_repo(
async_profiler_repos,
"async_profiler",
"async_profiler_linux_arm64",
"async_profiler_linux_x64",
"async_profiler_macos",
)

# =========================================
# Other Bazel testing dependencies
# =========================================
Expand Down
205 changes: 205 additions & 0 deletions MODULE.bazel.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit e586a5e

Please sign in to comment.