Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix print format args in RBE repo checked in configs validation #904

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Fix print format args in RBE repo checked in configs validation #904

merged 1 commit into from
Aug 14, 2020

Conversation

sunjayBhatia
Copy link
Contributor

Supercedes #837 as it seems to have gone stale

Taken suggestion from: #837 (comment)

We run into this as an issue when generating toolchains in a workspace with Linux and Windows toolchains, generating the Linux toolchains while there are others with checked in configs seems to hit this code and fail with: not all arguments converted during string formatting.

Taken suggestion from: #837 (comment)

Signed-off-by: William A Rowe Jr <[email protected]>
Co-authored-by: Sunjay Bhatia <[email protected]>
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@sunjayBhatia
Copy link
Contributor Author

@googlebot I signed it!

2 similar comments
@sunjayBhatia
Copy link
Contributor Author

@googlebot I signed it!

@sunjayBhatia
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@sunjayBhatia
Copy link
Contributor Author

cc @wrowe

@sunjayBhatia
Copy link
Contributor Author

cc @smukherj1 when you get a chance

@smukherj1
Copy link
Collaborator

/gcbrun

@sunjayBhatia
Copy link
Contributor Author

@smukherj1 when you get a chance looks like this is all green

@smukherj1 smukherj1 merged commit 022dcbb into bazelbuild:master Aug 14, 2020
@smukherj1
Copy link
Collaborator

huh, wonder where the prow bot is gone. It should have added the "lgtm" and "approval" labels and our auto merger should have automatically picked it when once the CI was green

@sunjayBhatia sunjayBhatia deleted the fix-print-format-args branch November 19, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants