-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix print format args in RBE repo checked in configs validation #904
Fix print format args in RBE repo checked in configs validation #904
Conversation
Taken suggestion from: #837 (comment) Signed-off-by: William A Rowe Jr <[email protected]> Co-authored-by: Sunjay Bhatia <[email protected]>
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
cc @wrowe |
cc @smukherj1 when you get a chance |
/gcbrun |
@smukherj1 when you get a chance looks like this is all green |
huh, wonder where the prow bot is gone. It should have added the "lgtm" and "approval" labels and our auto merger should have automatically picked it when once the CI was green |
Supercedes #837 as it seems to have gone stale
Taken suggestion from: #837 (comment)
We run into this as an issue when generating toolchains in a workspace with Linux and Windows toolchains, generating the Linux toolchains while there are others with checked in configs seems to hit this code and fail with:
not all arguments converted during string formatting
.