Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Build with bazel #340

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

build: Build with bazel #340

wants to merge 7 commits into from

Conversation

cameron-martin
Copy link
Collaborator

@cameron-martin cameron-martin commented Feb 3, 2024 •
edited
Loading

TODO:

  • Include either node_modules or bundle the app before packaging (probably bundling is better).
  • Work out how to build protobufs
  • Update documentation
  • Run linting with bazel
  • Update bazelci

Fixes #200

@cameron-martin
Build with bazel
e0bb497 
TODO:

- [ ] Finish building protobufs
- [ ] Update documentation
- [ ] Run linting with bazel
- [ ] Update bazelci
@cameron-martin
Remove old CI
693cac5
@cameron-martin
Use protobufs from bazel directly
80e6ad7
@cameron-martin
WIP: Proto compilation
63c3937
@cameron-martin cameron-martin changed the title Build with bazel build: Build with bazel Apr 2, 2024
@vogelsgesang vogelsgesang mentioned this pull request Apr 2, 2024
Merged
@cwahbong cwahbong mentioned this pull request Oct 22, 2024
Open
@cameron-martin
Merge branch 'master' into build-with-bazel
f9ca153
@cameron-martin
Upgrade bazel
858974f
@cameron-martin
Vendor bazel protobufs
bbd883f 
This updates the vendoring of bazel protobufs to include the original BUILD files. This uses buildozer and a bit of sed to update the BUILD files, including label paths, protobuf import paths and remove a lot of unused rules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coeuvre coeuvre Awaiting requested review from coeuvre coeuvre will be requested when the pull request is marked ready for review coeuvre is a code owner

@jfirebaugh jfirebaugh Awaiting requested review from jfirebaugh jfirebaugh will be requested when the pull request is marked ready for review jfirebaugh is a code owner

@vogelsgesang vogelsgesang Awaiting requested review from vogelsgesang vogelsgesang will be requested when the pull request is marked ready for review vogelsgesang is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build with bazel
1 participant
@cameron-martin