Enable scala_macro_library targets to have dependencies #1681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @jadenPete, thanks for PR. Are failing tests related to your changes? |
|
No problem! Yes, my changes caused those failures. I just pushed a fix. |
|
No problem! Let me rebase this branch, after which it can be merged. |
jadenPete
force-pushed
the
fix-scala-macro-library-dependencies
branch
from
a8991a6 to
0dd3073
Compare
|
Squashed. |
jadenPete
force-pushed
the
fix-scala-macro-library-dependencies
branch
from
0dd3073 to
905cf96
Compare
|
Done! |
liucijus
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR should fix #445. Before, macro targets couldn't depend on
ijard targets because targets depending on those macros would get the compile (ijard) versions of thoseijard targets, which can't be executed at compile time due to necessary information being stripped out. Instead, we need to include macro targets' transitive runtime JARs on the compile classpath.This PR makes Scala targets export a
ScalaInfoprovider containing acontains_macrosattribute. If one of a target's dependencies exports aScalaInfoprovider withcontains_macrosset toTrue(i.e. the dependency is a macro), that dependencies' transitive runtime JARs are hoisted to the top of the compile classpath. This is necessary because if they were included anywhere else in the classpath, we'd risk the compile-time versions of those transitive runtime JARs being used instead.The approach is explained in more detail in
collect_jarsinscala/private/common.bzl. Another benefit of this approach is that we canijarmacro targets and their transitive dependencies and therefore benefit from reduced incremental build times.Motivation
Closing #445.