fix(pypi): allow pip_compile to work with read-only sources #2712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbeasley-avgo
requested review from
rickeylev,
aignas and
groodt
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validating
py_testgenerated bycompile_pip_requirementschokes when the sourcerequirements.txtis stored read-only, such as when managed by the Perforce Helix Core SCM. Thoughdependency_resolvermakes a temporary copy of this file, it does so w/shutil.copywhich preserves the original read-only file mode. To address this, this commit replacesshutil.copywith ashutil.copyfileobjsuch that the temporary file is created w/ permissions according to the user's umask.Resolves (#2608).