fix: remove unused bad symlink in nodejs_repo_host_os_alias #3753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
fix_bzlmod_nodejs_host_2
branch
from
f9c14f3
to
a12e4bf
Compare
jbedard
reviewed
Jun 6, 2024
jbedard
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3720.
This repository symlink is dangling under bzlmod since the repository name the symlink is pointing to is not the same. It is safe to remove it as it is not in use anywhere.
The dangling symlink was identified due to a crash in bazel 7.1.0rc1 where the non-existant file was watched:. See bazelbuild/bazel#21483 (comment).