Gazelle: detect any directory with /test in path as test package #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detect any directory with /test in path as test package
illicitonion
reviewed
Sep 3, 2024
|
Thanks for the contribution! |
Co-authored-by: Daniel Wagner-Hall <[email protected]>
illicitonion
reviewed
Sep 3, 2024
There was a problem hiding this comment.
Please could you add a couple of new test-cases to https://github.com/bazel-contrib/rules_jvm/blob/main/java/gazelle/private/java/java_test.go (one for test at the end, one for testutil in the middle) to make sure this behaviour doesn't regress? Otherwise, happy to merge! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have not very java-like structure in our monorepo:
So current func IsTestPackage doesn't detect our tests as tests and we have
found MULTIPLE results in rule indexerror because of the same package in test classes.We propose the fix, so files in packages like
//common/testwill also fit as test packages.