Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timestamp and hostname to testsuite xml #294

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Add timestamp and hostname to testsuite xml #294

merged 1 commit into from
Aug 8, 2024

Conversation

brian-mcnamara
Copy link
Contributor

Fixed #293

Per https://windyroad.com.au/dl/Open%20Source/JUnit.xsd timestamp and hostname are required attributes on the testsuite tag.

shs96c
shs96c approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm slightly worried about the potential network call during the hostname lookup, but the exception should handle that case.

Thank you for the PR!

@shs96c shs96c enabled auto-merge (squash) August 8, 2024 09:10
@shs96c shs96c merged commit ca23db3 into bazel-contrib:main Aug 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shs96c shs96c shs96c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Junit5: XML output does not adhere to JUnit schema
2 participants
@brian-mcnamara @shs96c