refactor: remove runner attribute from create_jvm_test_suite #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francine-blanc
force-pushed
the
remove-runner-attr-from-create-jvm-test-suite-macro
branch
from
cfeb190
to
9f4b528
Compare
|
A consequence of this changes is that for existing users, the |
|
That’s fine. This macro is seldom used, as it’s a building block for the
higher level suite macros.
|
|
@shs96c would you be able to trigger the pipeline again please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
create_jvm_test_suite.bzl, therunnerattribute is not utilised within thedefine_testfunction. By the time we reach thecreate_jvm_test_suitemacro, this attribute is redundant because the specific test runner can be directly specified within thedefine_testfunction provided by the user. So, this PR removes references to the runner from the macro.