Fix "panic: runtime error: invalid memory address or nil pointer dereference" #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszpop
changed the title
illicitonion
added a commit
to illicitonion/rules_jvm
that referenced
this pull request
May 2, 2024
We're using this to find the parent of a package, not a filesystem path, and packages always use `/`. Fixes bazel-contrib#260 Closes bazel-contrib#261
|
Thanks for your fix! (And all your fixes - I've been working today on getting our CI running on Windows so we can catch this kind of problem in the future and make sure things work and keep working). I think #264 is a slightly more targeted fix - does that look good to you? |
@illicitonion LGTM, I checked on my local and your fix also works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
bazel run gazellefailing on Windows withbecause of the incorrect path separator when accessing the Configs map (#260).