lock file for maven in bzlmod #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@illicitonion hey can you please reapprove, fixed tests |
auto-merge was automatically disabled
April 11, 2024 14:43
Head branch was pushed to by a user without write access
|
Fixed gazelle test, sadly i can't launch pr checks myself. |
|
After your first PR gets merged, CI will run automatically for future PRs :) Thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#251
Existing frozen_deps_install.json doesn't match contrib_rules_jvm_deps_install.json generated by bzlmod version of maven.install, so i think we can replace old one only after full migration to bzlmod and use single version of maven.install