Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rules_jvm_external to 6.0 #250

Closed

Conversation

lyao-77
Copy link
Contributor

@lyao-77 lyao-77 commented Feb 26, 2024

We use java_export in our project and need to use some new feature that was added in to newly released rules_jvm_external

Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

I'll investigate the CI failure, as I think it's probably a bug in rules_jvm_external rather than anything to do with this PR. You don't need to worry about that error.

@@ -51,7 +51,7 @@ bazel_dep(
)
bazel_dep(
name = "rules_jvm_external",
version = "5.3",
version = "6.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the repositories.bzl file too? The versions of rules_jvm_external needs to match both here and there.

@shs96c
Copy link
Collaborator

shs96c commented Jul 12, 2024

Another PR (#288) updated contrib_rules_jvm to rules_jvm_external 6.2. Closing this, but thank you for your PR

@shs96c shs96c closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants