Rework how the junit xml-style log file is generated #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shs96c
force-pushed
the
junit-log-files
branch
from
c9aca53
to
bdaea57
Compare
illicitonion
reviewed
Nov 8, 2023
...com/github/bazel_contrib/contrib_rules_jvm/comparative/DisabledSkippedParameterisedTest.java
Outdated
Show resolved
Hide resolved
java/src/com/github/bazel_contrib/contrib_rules_jvm/junit5/BazelJUnitOutputListener.java
Outdated
Show resolved
Hide resolved
java/src/com/github/bazel_contrib/contrib_rules_jvm/junit5/BazelJUnitOutputListener.java
Outdated
Show resolved
Hide resolved
java/src/com/github/bazel_contrib/contrib_rules_jvm/junit5/BazelJUnitOutputListener.java
Show resolved
Hide resolved
...ative-tests/src/test/java/com/github/bazel_contrib/contrib_rules_jvm/comparative/BUILD.bazel
Show resolved
Hide resolved
illicitonion
approved these changes
Nov 8, 2023
...ire-reports/TEST-com.github.bazel_contrib.contrib_rules_jvm.comparative.PathologicalTest.xml
Outdated
Show resolved
Hide resolved
shs96c
force-pushed
the
junit-log-files
branch
2 times, most recently
from
6e86e22
to
bb23851
Compare
blorente
approved these changes
Nov 8, 2023
java/src/com/github/bazel_contrib/contrib_rules_jvm/junit5/BazelJUnitOutputListener.java
Outdated
Show resolved
Hide resolved
java/src/com/github/bazel_contrib/contrib_rules_jvm/junit5/README.md
Outdated
Show resolved
Hide resolved
...ative-tests/src/test/java/com/github/bazel_contrib/contrib_rules_jvm/comparative/BUILD.bazel
Show resolved
Hide resolved
...urefire-reports/TEST-com.github.bazel_contrib.contrib_rules_jvm.comparative.DynamicTests.xml
Outdated
Show resolved
Hide resolved
shs96c
force-pushed
the
junit-log-files
branch
from
bb23851
to
901178b
Compare
rdesgroppes
reviewed
Jan 4, 2024
| result.toXml(xsw); | ||
|
|
||
| renderer.accept(xsw); | ||
| System.out.println(writer); |
There was a problem hiding this comment.
System.out.println: leftover?
There was a problem hiding this comment.
Oops. Yes. Leftover.
There was a problem hiding this comment.
Created #228 to fix this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.