Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for test_suffixes_excludes #218

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Implement support for test_suffixes_excludes #218

merged 3 commits into from
Nov 15, 2023

Conversation

guw
Copy link
Contributor

@guw guw commented Nov 1, 2023

This addresses #215

@guw
Copy link
Contributor Author

guw commented Nov 8, 2023

@illicitonion @shs96c Can we can this reviewed? 🙏

shs96c
shs96c approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the PR!

@shs96c
Copy link
Collaborator

shs96c commented Nov 10, 2023

@guw, I'm happy to merge this, but I think there's a conflict in the .gitignore file. Would you be able to resolve this?

@guw
Copy link
Contributor Author

guw commented Nov 10, 2023

@shs96c Done. Thanks!

@shs96c shs96c merged commit 74a79f5 into bazel-contrib:main Nov 15, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shs96c shs96c shs96c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guw @shs96c