Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the default config in spotbugs_test #187

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Fix the default config in spotbugs_test #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f0f8ab
Fix the default config in `spotbugs_test`
chrismgrayftsinc Jul 17, 2023
4d0d393
Fix the README.
chrismgrayftsinc Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ Use spotbugs to lint the `srcs`.
| Name | Description | Type | Mandatory | Default |
| :------------- | :------------- | :------------- | :------------- | :------------- |
| <a id="spotbugs_test-name"></a>name | A unique name for this target. | <a href="https://bazel.build/concepts/labels#target-names">Name</a> | required | |
| <a id="spotbugs_test-config"></a>config | - | <a href="https://bazel.build/concepts/labels">Label</a> | optional | <code>//java:spotbugs-default-config</code> |
| <a id="spotbugs_test-config"></a>config | - | <a href="https://bazel.build/concepts/labels">Label</a> | optional | <code>@contrib_rules_jvm//java:spotbugs-default-config</code> |
| <a id="spotbugs_test-deps"></a>deps | - | <a href="https://bazel.build/concepts/labels">List of labels</a> | required | |
| <a id="spotbugs_test-only_output_jars"></a>only_output_jars | If set to true, only the output jar of the target will be analyzed. Otherwise all transitive runtime dependencies will be analyzed | Boolean | optional | <code>True</code> |

Expand Down
2 changes: 1 addition & 1 deletion java/private/spotbugs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ spotbugs_test = rule(
allow_files = False,
),
"config": attr.label(
default = "//java:spotbugs-default-config",
default = "@contrib_rules_jvm//java:spotbugs-default-config",
providers = [
SpotBugsInfo,
],
Expand Down