Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#104): Allow custom package prefixes #121

Merged

Conversation

hjellek
Copy link
Contributor

@hjellek hjellek commented Jan 11, 2023

First of all: Thanks a lot for these rules!

Attempt at making the package prefixes configurable, instead of populating _PREFIXES with all known values.

I need suppport for .no. domains for example, and based on #104 there are many more wishes for package prefixes out there.

Feedback and improvements are welcome!

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@illicitonion illicitonion merged commit f0a9a36 into bazel-contrib:main Jan 11, 2023
@hjellek hjellek deleted the make_java_package_prefix_configurable branch January 11, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants