Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No maven lockfile for bzlmod #251

Open
firov opened this issue Mar 14, 2024 · 0 comments
Open

No maven lockfile for bzlmod #251

firov opened this issue Mar 14, 2024 · 0 comments

Comments

@firov
Copy link
Contributor

firov commented Mar 14, 2024 •
edited
Loading

MODULE.bazel maven.install does not use lock_file (docs)

If i try to add it, build fails with

 no such target '@@rules_jvm_external~6.0~maven~contrib_rules_jvm_deps//:com_puppycrawl_tools_checkstyle'

I suppose problem in _artifact macro

Bzlmod support done here: #170 #123
@firov firov mentioned this issue Mar 14, 2024
Merged
illicitonion pushed a commit that referenced this issue Apr 11, 2024
@firov
lock file for maven in bzlmod (#252)
87f46b0 
#251

Existing frozen_deps_install.json doesn't match
contrib_rules_jvm_deps_install.json generated by bzlmod version of
maven.install, so i think we can replace old one only after full
migration to bzlmod and use single version of maven.install

---------

Co-authored-by: Nikolay Firov <[email protected]>
Co-authored-by: Nikolay Firov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@firov