Skip to content

Commit

Permalink
Revert "Convert package to filepath"
Browse files Browse the repository at this point in the history
This reverts commit 904958f.
  • Loading branch information
illicitonion committed May 8, 2024
1 parent be70ff5 commit f2538bf
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions java/gazelle/generate.go
Original file line number Diff line number Diff line change
Expand Up @@ -134,18 +134,17 @@ func (l javaLang) GenerateRules(args language.GenerateArgs) language.GenerateRes
}
allPackageNames.Add(mJavaPkg.Name)

mRelFilepath := filepath.FromSlash(mRel)
if !mJavaPkg.TestPackage {
addNonLocalImportsAndExports(productionJavaImports, nonLocalJavaExports, mJavaPkg.ImportedClasses, mJavaPkg.ImportedPackagesWithoutSpecificClasses, mJavaPkg.ExportedClasses, mJavaPkg.Name, javaClassNamesFromFileNames)
for _, f := range mJavaPkg.Files.SortedSlice() {
productionJavaFiles.Add(filepath.Join(mRelFilepath, f))
productionJavaFiles.Add(filepath.Join(mRel, f))
}
allMains.AddAll(mJavaPkg.Mains)
} else {
// Tests don't get to export things, as things shouldn't depend on them.
addNonLocalImportsAndExports(testJavaImports, nil, mJavaPkg.ImportedClasses, mJavaPkg.ImportedPackagesWithoutSpecificClasses, mJavaPkg.ExportedClasses, mJavaPkg.Name, javaClassNamesFromFileNames)
for _, f := range mJavaPkg.Files.SortedSlice() {
path := filepath.Join(mRelFilepath, f)
path := filepath.Join(mRel, f)
file := javaFile{
pathRelativeToBazelWorkspaceRoot: path,
pkg: mJavaPkg.Name,
Expand All @@ -164,7 +163,7 @@ func (l javaLang) GenerateRules(args language.GenerateArgs) language.GenerateRes
}
allMains.AddAll(javaPkg.Mains)
for _, f := range javaFilenamesRelativeToPackage {
path := filepath.Join(filepath.FromSlash(args.Rel), f)
path := filepath.Join(args.Rel, f)
if javaPkg.TestPackage {
file := javaFile{
pathRelativeToBazelWorkspaceRoot: path,
Expand Down

0 comments on commit f2538bf

Please sign in to comment.