Move sample PMD config into //java

This means that users won't be exposed to the gazelle dependency in the top-level build file.
bazel-contrib · Dec 17, 2021 · d693d60 · d693d60
1 parent 06c1f60
commit d693d60
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 14 deletions.
diff --git a/BUILD.bazel b/BUILD.bazel
@@ -1,16 +1,5 @@
 load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 load("@bazel_gazelle//:def.bzl", "gazelle", "gazelle_binary")
-load("//java/private:pmd_ruleset.bzl", "pmd_ruleset")
-
-pmd_ruleset(
-    name = "pmd-config",
-    rulesets = [
-        "pmd-ruleset.xml",
-    ],
-    visibility = [
-        "//visibility:public",
-    ],
-)
 
 gazelle_binary(
     name = "gazelle_bin",

diff --git a/README.md b/README.md
@@ -30,7 +30,7 @@ load("@apple_rules_lint//lint:setup.bzl", "lint_setup")
 lint_setup({
   # Note: this is an example config!
   "java-checkstyle": "@contrib_rules_jvm//java:checkstyle-default-config",
-  "java-pmd": "//:pmd-config",
+  "java-pmd": "@contrib_rules_jvm//java:pmd-config",
   "java-spotbugs": "@contrib_rules_jvm//java:spotbugs-default-config",
 })
 ```

diff --git a/WORKSPACE b/WORKSPACE
@@ -17,7 +17,7 @@ load("@apple_rules_lint//lint:setup.bzl", "lint_setup")
 
 lint_setup({
     "java-checkstyle": "//java:checkstyle-default-config",
-    "java-pmd": "//:pmd-config",
+    "java-pmd": "//java:pmd-config",
     "java-spotbugs": "//java:spotbugs-default-config",
 })
 

diff --git a/docs/preamble.md b/docs/preamble.md
@@ -30,7 +30,7 @@ load("@apple_rules_lint//lint:setup.bzl", "lint_setup")
 lint_setup({
   # Note: this is an example config!
   "java-checkstyle": "@contrib_rules_jvm//java:checkstyle-default-config",
-  "java-pmd": "//:pmd-config",
+  "java-pmd": "@contrib_rules_jvm//java:pmd-config",
   "java-spotbugs": "@contrib_rules_jvm//java:spotbugs-default-config",
 })
 ```

diff --git a/java/BUILD.bazel b/java/BUILD.bazel
@@ -2,6 +2,7 @@ load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 load("//java/private:artifact.bzl", "artifact")
 load("//java/private:checkstyle_config.bzl", "checkstyle_config")
 load("//java/private:spotbugs_config.bzl", "spotbugs_config")
+load("//java/private:pmd_ruleset.bzl", "pmd_ruleset")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -58,6 +59,16 @@ java_binary(
     ],
 )
 
+pmd_ruleset(
+    name = "pmd-config",
+    rulesets = [
+        "pmd-ruleset.xml",
+    ],
+    visibility = [
+        "//visibility:public",
+    ],
+)
+
 bzl_library(
     name = "defs",
     srcs = ["defs.bzl"],

diff --git a/pmd-ruleset.xml → java/pmd-ruleset.xml b/pmd-ruleset.xml → java/pmd-ruleset.xml