fix(replayer): replay corpus files in hidden dirs

[simonresch]

The replayer would not execute hidden corpus files or files in hidden directories if they were in the bazel project root (#253).

[fmeum]

The fix looks good to me. Hidden files can always be filtered out with a glob in Bazel, which is far more flexible.

Wouldn't hidden files in subdirectories also have been filtered out though? This doesn't look specific to the root (d_name should just contain the basename of an entry).

@stefanbucur Could you review this for approval?

[simonresch]

The fix looks good to me. Hidden files can always be filtered out with a glob in Bazel, which is far more flexible.

Wouldn't hidden files in subdirectories also have been filtered out though? This doesn't look specific to the root (d_name should just contain the basename of an entry).

@stefanbucur Could you review this for approval?

Thanks for taking a look @fmeum!

I think hidden files in sub directories works for me since the replayer is started with a prepared corpus directory with file names based on the full path inside the bazel project. E.g. src/.hidden/foo end up in the corpus directory as src-.hidden-foo which was not filtered out (see https://github.com/bazelbuild/rules_fuzzing/blob/691c8938ff87681f7281cc4ba840e74e3b63c54b/fuzzing/tools/make_corpus_dir.py#L63).

[stefanbucur]

Thanks for the fix!

[simonresch]

@stefanbucur I added a second commit to update the upload-artifact action. This should get the OSS Fuzz github workflow going again. Could you take another look?