Update abseil-cpp to fix build with Clang >=16 #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinlinden
requested review from
asraa,
inferno-chromium,
fniksic,
oliverchang,
stefanbucur and
xinhaoyuan
as code owners
robinlinden
force-pushed
the
update-abseil-cpp
branch
from
cd6d0dd
to
6fae0aa
Compare
This fixes a build error in newer Clang caused by a
feature=layering_check violation:
```
In file included from external/com_google_absl/absl/debugging/stacktrace.cc:46:
external/com_google_absl/absl/debugging/internal/stacktrace_x86-inl.inc:38:10: error: module @com_google_absl//absl/debugging:stacktrace does not depend on a module exporting 'absl/base/internal/raw_logging.h'
^
1 error generated.
```
robinlinden
force-pushed
the
update-abseil-cpp
branch
from
6fae0aa
to
445add9
Compare
robinlinden
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: abseil-cpp started requiring C++14 in the 2023 January LTS release, so if this is merged, users on old compilers may have to override abseil-cpp to an older version.
This fixes a build error in newer Clang caused by a
feature=layering_check violation:
This commit in abseil-cpp fixing the error is
https://github.com/abseil/abseil-cpp/commit/f753eb27d03c9900aa65c4568c0420334cd28aab.