Update and simplify Jazzer integration #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
update-jazzer
branch
12 times, most recently
from
b564483
to
57eea1c
Compare
fmeum
force-pushed
the
update-jazzer
branch
2 times, most recently
from
c81bfd2
to
cbc8776
Compare
fmeum
force-pushed
the
update-jazzer
branch
3 times, most recently
from
5af1ed5
to
cf3b8b7
Compare
fmeum
requested review from
asraa,
inferno-chromium,
fniksic,
oliverchang,
stefanbucur and
xinhaoyuan
as code owners
|
@stefanbucur Could you review? Let me know if you want me to add more information about what changed in Jazzer and how it affects rules_fuzzing. |
stefanbucur
requested changes
Jun 30, 2023
fuzzing/private/runtime/BUILD
Outdated
Comment on lines
21
to
49
| clang_runtime_lib( | ||
| name = "asan_linux", | ||
| basenames = [ | ||
| # LLVM 15+ | ||
| "libclang_rt.asan.so", | ||
| # LLVM 14 and earlier | ||
| "libclang_rt.asan-x86_64.so", | ||
| ], | ||
| ) | ||
|
|
||
| clang_runtime_lib( | ||
| name = "asan_macos", | ||
| basenames = ["libclang_rt.asan_osx_dynamic.dylib"], | ||
| ) | ||
|
|
||
| clang_runtime_lib( | ||
| name = "ubsan_linux", | ||
| basenames = [ | ||
| # LLVM 15+ | ||
| "libclang_rt.ubsan_standalone.so", | ||
| # LLVM 14 and earlier | ||
| "libclang_rt.ubsan_standalone-x86_64.so", | ||
| ], | ||
| ) | ||
|
|
||
| clang_runtime_lib( | ||
| name = "ubsan_macos", | ||
| basenames = ["libclang_rt.ubsan_osx_dynamic.dylib"], | ||
| ) |
There was a problem hiding this comment.
Should these rules always be defined? I believe Bazel supports specifying compatibility criteria: https://bazel.build/extending/platforms#skipping-incompatible-targets
There was a problem hiding this comment.
It does, but that doesn't factor into target selection, it just improves error messages and makes wildcard builds pass. Here, I had tags = ["manual"] in the macro, which was arguably too magic - I moved it out into the BUILD file.
| visibility = ["//visibility:public"], | ||
| ) | ||
|
|
||
| java_library( |
There was a problem hiding this comment.
Maybe explain in a comment the role of this rule? It seems to provide no functionality?
stefanbucur
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates Jazzer to v0.17.1 and restores compatibility with OSS-Fuzz after its recent Jazzer update.
Since Jazzer can now be run directly as a
java_binaryobtained from Maven, the setup required forjava_fuzz_testhas been simplified:The Jazzer update also makes rules_fuzzing compatible with Bazel 6.