Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade bsdtar to 3.7.4 #866

Merged
merged 1 commit into from
Jun 17, 2024
Merged

chore: upgrade bsdtar to 3.7.4 #866

merged 1 commit into from
Jun 17, 2024

Conversation

alexeagle
Copy link
Collaborator


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

bsdtar is now version 3.7.4 and includes some improvements to how its compiled, see bazelbuild/bazel-central-registry#1916

Test plan

  • Covered by existing test cases

@alexeagle alexeagle requested a review from thesayyn June 16, 2024 02:07
Copy link

aspect-workflows bot commented Jun 16, 2024

Test

6 test targets passed

Targets
//lib/tests/copy_to_directory_bin_action:test [k8-fastbuild] 110ms
//lib/tests/jq:check_stamped [k8-fastbuild]                  294ms
//lib/tests/tar:test_compress [k8-fastbuild]                 312ms
//lib/tests/tar:test_genrule [k8-fastbuild]                  265ms
//lib/tests/yq:check_stamped [k8-fastbuild]                  437ms
//lib/tests/zstd:test_decompressed [k8-fastbuild]            366ms

Total test execution time was 2s. 211 tests (97.2%) were fully cached saving 43s.


Test

e2e/copy_action

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/copy_to_directory

All tests were cache hits

6 tests (100.0%) were fully cached saving 583ms.


Test

e2e/coreutils

All tests were cache hits

4 tests (100.0%) were fully cached saving 423ms.


Test

e2e/external_copy_to_directory

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/smoke

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.


Buildifier      Format      Gazelle

@alexeagle
Copy link
Collaborator Author

This still uses the windows .exe from the libarchive distribution, so I guess that doesn't fix #848
@peakschris I think we need to change https://github.com/aspect-build/bsdtar-prebuilt/blob/main/.github/workflows/release.yml to also build .exe - not sure if we can cross-compile for that, or need to add Windows GHA runners

@peakschris
Copy link

@alexeagle thanks for trying, sounds complex...

@thesayyn
Copy link
Collaborator

This still uses the windows .exe from the libarchive distribution, so I guess that doesn't fix #848 @peakschris I think we need to change https://github.com/aspect-build/bsdtar-prebuilt/blob/main/.github/workflows/release.yml to also build .exe - not sure if we can cross-compile for that, or need to add Windows GHA runners

i believe cross-compilation works now.

Copy link
Collaborator

@thesayyn thesayyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can fix libarchive-prebuilt to include windows binaries.

@alexeagle alexeagle merged commit 3330c38 into main Jun 17, 2024
35 checks passed
@alexeagle alexeagle deleted the up_tar branch June 17, 2024 14:49
@alexeagle
Copy link
Collaborator Author

Nice, filed aspect-build/bsdtar-prebuilt#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants