Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(tar_toolchains): also search for bsdtar on host platform #789

Closed
wants to merge 1 commit into from

Conversation

pcj
Copy link

@pcj pcj commented Mar 14, 2024

Fixes #788


Type of change

  • Bug fix

Test plan

No change in test coverage.

@CLAassistant
Copy link

CLAassistant commented Mar 14, 2024

CLA assistant check
All committers have signed the CLA.

@pcj pcj changed the title improvement(tar_toolchains): also search for bsdtar for host platform improvement(tar_toolchains): also search for bsdtar on host platform Mar 14, 2024
@pcj
Copy link
Author

pcj commented Mar 14, 2024

Context: in nix, bsdtar is provided by the libarchive package:

$ which bsdtar
/nix/store/w9m2y5kpmgs342fnmksirvhiqrmqh08j-libarchive-3.6.2/bin/bsdtar

@alexeagle
Copy link
Collaborator

Thanks! But our plan has been to provide a pre-built bsdtar binary for darwin as well - this is replaced by #804

@alexeagle alexeagle closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: bsdtar toolchain fails on macOS if host tar is gnutar
3 participants